Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizing inheritance for fluid-object #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bmiww
Copy link

@bmiww bmiww commented Nov 5, 2023

Fixes an error where the first time the fluid-object is being instantiated - its class inheritance is not yet finalized.
Affects cases where a the with-decoder-simple-clos-semantics is used without an explicit class (a default fluid-object class is used).

Fixes 4 of the test cases:

TEST-ENCODE-JSON-CLOS-MAX-PACKAGE in JSON []:
TEST-ENCODE-JSON-CLOS in JSON []:
JSON-OBJECT-WITH-PROTOTYPE in JSON []:
JSON-OBJECT in JSON []:

I've only tested this with SBCL so far.
Haven't tested it in too much effort yet, but as far as i understand - when new classes/slots would appear - the class would go through reinitialization anyways, so I'm not expecting this to have negative effects.
(not an expert though :) )

@bmiww bmiww mentioned this pull request Nov 5, 2023
This was causing crashes in sbcl when spamming the stream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant